Re: [PATCH 1/2] xfstests: add helper require function _require_btrfs_cloner

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 23 May 2014 05:05:30 +0100, Filipe David Borba Manana wrote:

> So that the same check (btrfs cloner program presence) can be reused
> by other tests.
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
> ---
>  common/rc       | 7 +++++++
>  tests/btrfs/035 | 4 +---
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/common/rc b/common/rc
> index d1788d1..f27ee53 100644
> --- a/common/rc
> +++ b/common/rc
> @@ -2085,6 +2085,13 @@ _require_fssum()
>  	[ -x $FSSUM_PROG ] || _notrun "fssum not built"
>  }
>  
> +_require_btrfs_cloner()
> +{
> +	CLONER_PROG=$here/src/cloner
> +	[ -x $CLONER_PROG ] || \
> +		_notrun "cloner binary not present at $CLONER_PROG"
> +}

Would prefer to avoid the reliance on $here, but it appears that other
common/rc functions make the same assumption.

Reviewed-by: David Disseldorp <ddiss@xxxxxxx>

Cheers, David
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux