Re: [PATCH 1/2] btrfs: label should not contain return char

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 20/05/14 01:19, Roman Mamedov wrote:
On Tue, 20 May 2014 01:04:30 +0800
Anand Jain <anand.jain@xxxxxxxxxx> wrote:

From: Anand Jain <Anand.Jain@xxxxxxxxxx>

generally if you use
   echo "test" > /sys/fs/btrfs/<fsid>/label
it would introduce return char at the end and it can not
be part of the label. The correct command is
   echo -n "test" > /sys/fs/btrfs/<fsid>/label

This patch will check for this user error

Maybe instead consider checking for one trailing "\n", and silently remove it
if passed, so that both of the mentioned variants of 'echo' can be used?

All other sysfs files do not care if you pass an extra "\n" at the end, e.g.

   echo cfq > /sys/block/sda/queue/scheduler

works fine, doesn't require you to use "echo -n cfq".


Thanks Roman.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux