Re: [PATCH 07/14] btrfs-progs: Print more info about device sizes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 30, 2014 at 01:39:27PM +0200, Goffredo Baroncelli wrote:
> >> Sample:
> >> /dev/sda7, ID: 3
> >>    Device size:            10.00GiB
> >>    FS occuppied:            5.00GiB
> > 
> > Spelling mistake.  s/occuppied/occupied/.
> 
> I found a bit unclear the "FS occupied" terms. 

We're running out of terms to describe and distinguish the space that
the filesystem uses.

Here's what we have already:

- used
- allocated
- reserved
- total

'occupied' seemed like a good choice to me, though it may be not obvious
at first. The rationale behind is to denote space that the filesystem
can potentially use on the device - in one word.

> Can I suggest "Resized to:" instead of "FS occupied:", and to show it
> only when the two values differ ? In fact this value has a meaning
> only if a filesystem is resized.

'Resized to' sounds good to me and makes sense in the context of the
output:

/dev/sda6, ID: 2
   Device size:            10.00GiB
   Resized to:              5.00GiB
   Data,RAID10:           512.00MiB
   Metadata,RAID10:       512.00MiB
   System,RAID10:           4.00MiB
   Unallocated:             9.00GiB

The next point, display only if it's different from size. This makes
calculating the filesystem size conditional and if eg. I filter the
output I can't simply do 'grep -i occupied'.

The points against that are that this makes the output longer and the
resized devices are probably not the most common scenario.

So as a compromise, we can add an option to enable more verbose output.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux