Re: [PATCH] Btrfs: check if items are ordered when a leaf is marked dirty

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 09, 2014 at 03:37:06PM +0100, Filipe David Borba Manana wrote:
> To ease finding bugs during development related to modifying btree leaves
> in such a way that it makes its items not sorted by key anymore. Since this
> is an expensive check, it's only enabled if CONFIG_BTRFS_FS_CHECK_INTEGRITY
> is set, which isn't meant to be enabled for regular users.
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx>
Reviewed-by: David Sterba <dsterba@xxxxxxx>

> @@ -3695,6 +3695,12 @@ void btrfs_mark_buffer_dirty(struct extent_buffer *buf)
>  		__percpu_counter_add(&root->fs_info->dirty_metadata_bytes,
>  				     buf->len,
>  				     root->fs_info->dirty_metadata_batch);
> +#ifdef CONFIG_BTRFS_FS_CHECK_INTEGRITY
> +	if (btrfs_header_level(buf) == 0 && check_leaf(root, buf)) {

You coud also add the 'level == 0' to check_leaf() itself.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux