Re: [PATCH] Btrfs: all super blocks of the replaced disk must be scratched

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 17, 2014 at 07:58:06PM +0800, Anand Jain wrote:
> In a normal scenario when sys-admin replaces a disk, the
> expeted is btrfs will release the disk completely.
> 
> However the below test case gives a wrong impression that
> replaced disk is still is in use.
> 
> $ btrfs rep start /dev/sde /dev/sdg4 /btrfs
> $ mkfs.btrfs /dev/sde
> /dev/sde appears to contain an existing filesystem (btrfs).
> Error: Use the -f option to force overwrite.

(your signed-off is missing)

Reviewed-by: David Sterba <dsterba@xxxxxxx>

I've noticed that btrfs_rm_device also cleans only the first superblock
signature, so it should do the same.

I can't think of any drawback where all the superblocks are scratched,
should be safe.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux