On Sun, Mar 16, 2014 at 12:41:17AM +0000, quwenruo@xxxxxxxxxxxxxx wrote: > On Fri, 14 Mar 2014 15:39:03 +0100, David Sterba wrote: > > On Thu, Mar 06, 2014 at 04:19:50AM +0000, quwenruo@xxxxxxxxxxxxxx wrote: > >> @@ -23,11 +23,13 @@ > >> struct btrfs_workqueue; > >> /* Internal use only */ > >> struct __btrfs_workqueue; > >> +struct btrfs_work; > >> +typedef void (*btrfs_func_t)(struct btrfs_work *arg); > > I don't see what's wrong with the non-typedef type, CodingStyle > > discourages from using typedefs in general (Chapter 5). > > > > The name btrfs_func_t is a generic, if you really need to use a typedef > > here, please change it to something closer to the workqueues, eg. > > btrfs_work_func_t. > > > btrfs_func_t is just following the work_func_t naming style, > for btrfs it's only used to reduce the length of prototype definition. > > Since btrfs_func_t is only used in btrfs, this patch can be ignored. Thanks for considerations. In case of the generic workqueues interface it makes sense to provide a shortcut to the callback definition because it appears in many structures. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
