On Wed, Feb 19, 2014 at 07:17:51PM +0800, Wang Shilong wrote:
> +u64 btrfs_strtoull(char *str, int base)
> +{
> + u64 value;
> + char *ptr_parse_end = NULL;
> + char *ptr_str_end = str + strlen(str);
> +
> + value = strtoull(str, &ptr_parse_end, base);
> + if (ptr_parse_end != ptr_str_end) {
> + fprintf(stderr, "ERROR: %s is not an invalid unsigned long long integer.\n",
> + str);
> + exit(1);
Calling exit() in a helper function makes is unsuitable as a generic
helper or for use from any library function, though all the places where
it's used are in main() so it's similar to usage(), and makes handling
errors in command line arguments easier.
I'm still concerned about the generic function name, but don't have an
idea how to fix it atm.
> + }
> + if (value == ULONG_MAX) {
> + fprintf(stderr, "ERROR: %s is out of range.\n", str);
> + exit(1);
> + }
> + return value;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
