Re: [PATCH] btrfs: introduce BTRFS_IOC_GET_DEVS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





 Thanks for the comments.

 mainly here sysfs way defeats the purpose - debug as
 mentioned. Sysfs would/should show only mounted disks,
 the ioctl way doesn't have such a limitation (of course
 as I commented memory dump way would have been best choice
 but I got stuck with that approach if anybody wants to give
 a try with that approach you are most welcome).

 IMO no harm to have both sysfs way and ioctl way let user
 or developer use which were is suitable in their context.

Thanks, Anand


On 02/07/2014 06:05 AM, David Sterba wrote:
On Thu, Feb 06, 2014 at 09:09:57PM +0100, Goffredo Baroncelli wrote:
With 3.14 the sysfs interface is available, but the devices under
  /sys/fs/btrfs/<fs-uuid>/devices/...
are symlinks to the sysfs devices, so this btrfs-specific device
information has to be located in a separate directory.

yes please; it would scale better than the ioctl()s; anyway I suggest 1
file per property, and not "...one file that holds all the stats
  about the device"

Well, we can do both, I don't have a preference and both make sense.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux