Re: [PATCH] btrfs-progs: Convert BUG() to BUG_ON(1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Feb 6, 2014 at 3:22 PM, David Sterba <dsterba@xxxxxxx> wrote:
> On Thu, Feb 06, 2014 at 12:34:08PM -0600, Mitch Harder wrote:
>> Convert the instances of BUG() to BUG_ON(1) to provide information
>> about the location of the abort.
>
> kerncompat.h:
>
> #define BUG() abort()
>
> #define BUG_ON(c) assert(!(c))
>
> I'd rather fix the definition to do the same thing, that way no
> developer would need to know the difference (that actually exists only
> in the userspace tools, in kernel the two produce the same outout).
>
>
> david

Thanks for the feedback.

Changing the definition of BUG() in kerncompat.h will be much more concise.

I'll restructure the patch and resubmit it after I test it.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux