On Mon, Jan 27, 2014 at 02:28:26PM +0100, Gerhard Heift wrote: > This patch series adds a new ioctl TREE_SEARCH_V2 with which we could store the > results in a varying buffer. Now even items larger than 3992 bytes or a large > amount of items can be returned. > > I have a few questions: > Which value should I assign to TREE_SEARCH_V2? As you did it, it's ok. > Should we limit the buffer size? A sane limit would be ok, and as it's not hardcoded to the data structure, we can change it later if needed. The only requirement I see now is to fit the maximum node/leaf size, ie at least 64k. Big buffer allows to pack lots of items and save the overhead of ioctl call, but if this is an issue, a separate ioctl should be dedicated to do that. > What about documentation? I think it's good to document the ioctls in ioctl.h itself, (arguments and examples if it's not obvious) probably will hit the target audience. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
