Re: [PATCH] Btrfs-progs: Fix bus error on sparc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 16, 2014 at 09:22:57PM -0500, Ivan Jager wrote:
> After patching this I realized Liu Bo had already written a similar
> patch, but I think mine is cleaner, so I'm sending it anyway.

Thanks for taking the time, I like your version better and will replace
Liu Bo's patch in integration branch.

> If you like, I could also change the location->objectid references
> between my two changes, which would make the patch bigger, but would
> make it actually reduce the overall code size slightly.

Not necessary.

> Feel free to make or request any necessary style changes as I couldn't
> find documentation on the coding style for btrfs-tools.

I'ts the same as the kernel coding style, code and people are mostly the
shared.

> PS: Here is the gdb output in case anyone is interested.

It helps to verify how the unaligned access propagated, thanks.

I'll put your analysis as a changelog and the missing Signed-off-by
line from your name + email.
It's the "Developer's Certificate of Origin 1.1", see
http://lxr.free-electrons.com/source/Documentation/SubmittingPatches#L307
if you'r not familiar with this practice.


david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux