Re: [PATCH] btrfs: Cleanup the unused btrfs_check_super_valid.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 18, 2013 at 11:14:28AM +0800, Qu Wenruo wrote:
> Since in David's commit 1104a8855, there is nothing really check the
> super block now, the btrfs_check_super_valid function can be removed if
> no one else needs the function.
> 
> Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
> Cc: David Sterba <dsterba@xxxxxxx>
> ---
> -static int btrfs_check_super_valid(struct btrfs_fs_info *fs_info,
> -			      int read_only)
> -{
> -	/*
> -	 * Placeholder for checks

The comment should motivate to add more tests, not to remove the
supporting code. Please keep it.

> -	 */
> -	return 0;
> -}
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux