Re: [PATCH] Btrfs: move the extent buffer radix tree into the fs_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Dec 17, 2013 at 09:56:07AM -0500, Josef Bacik wrote:
> >* alloc_extent_buffer uses radix_preload that turns off preepmtion by
> >itself, so the lock here would be pointless
> 
> Except you still need a lock for other inserts.
> >
> >* release_extent_buffer locks around radix_tree_delete, here a rcu
> >locking will be ok as well
> 
> No it won't.  RCU just makes sure readers don't get screwed, you still need
> to have real locking around the insertions/deletions, look at pagecache, we
> have mapping->tree_lock for this even though it uses rcu for the lookups.

Oh, my bad sorry, that would be too easy.
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux