On Tue, Dec 17, 2013 at 07:58:24PM +0800, Wang Shilong wrote: > Nice work, Before this patch for btrfs send. > we have to join a transaction to avoid commit root changed. That sounds like a good improvement. > I send a plus patch that remove transaction protection from btrfs send. > and a little comment below. > > [...] > On 12/17/2013 12:34 AM, David Sterba wrote: > >All the subvolues that are involved in send must be read-only during the > > s via SUBVOL_SETFLAGS > >+ */ > >+ int send_in_progress; > > Why not use u32 here? The int type should be enough to hold refs for all running sends, if this is your concern. I thought it's a refcount, it should not go below 0 but if it does, then it should be caught. I'll update the patch to check if send_in_progress is not negative after the decrements. thanks, david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
