On Tue, Dec 3, 2013 at 8:43 AM, David Sterba <dsterba@xxxxxxx> wrote: > On Fri, Nov 29, 2013 at 07:55:37PM +0000, Filipe David Manana wrote: >> On Fri, Nov 29, 2013 at 3:45 PM, David Sterba <dsterba@xxxxxxx> wrote: >> > Hi, >> > >> > On Fri, Jul 05, 2013 at 09:32:05PM +0100, Filipe David Borba Manana wrote: >> >> If we're looking for a metadata item in the tree and the >> >> search fails with return value of 1, and the slot doesn't >> >> point to the first item in the leaf, check if the previous >> >> item in the leaf corresponds to an extent item for the same >> >> object id - if it does, then don't do another tree search >> >> to get it. >> > >> > I'm suspecting this patch to cause some trouble, see >> > https://bugzilla.kernel.org/show_bug.cgi?id=64961 >> >> What makes you believe the problem is exactly in this function? > > It was a first guess based on the stacktraces and last patch that > touched the code. I've replied to mailinlist because it has higher > visibility, number of bugreports in balance/relocation has been > increasing lately (not blaming you). > >> I read it again, and I can't see how it can miss an extent item that >> it couldn't before, specially without skinny metadata enabled. Did >> the fs had skinny metadata enabled? > > According to the updated bugzilla yes, and that's another possible > cause although we haven't seen bugs with skinny metadata yet. There's > another bugreport that has them enabled, > https://bugzilla.kernel.org/show_bug.cgi?id=66411 > I've been seeing similar issues while testing my qgroups patches that I don't think is related to my qgroup work. I'm going to try and track it down this week but I may not get to it until next week. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
