Re: [PATCH 05/16] btrfs-progs: don't leak fd in test_dev_for_mkfs() error paths

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Reviewed-by: Anand Jain <anand.jain@xxxxxxxxxx>


On 11/07/2013 07:15 AM, Eric Sandeen wrote:
Close fd before we return on error paths.

Resolves-Coverity-CID: 1125939
Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
---
  utils.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/utils.c b/utils.c
index c11a7c2..c784345 100644
--- a/utils.c
+++ b/utils.c
@@ -1905,10 +1905,12 @@ int test_dev_for_mkfs(char *file, int force_overwrite, char *estr)
  	if (fstat(fd, &st)) {
  		snprintf(estr, sz, "unable to stat %s: %s\n", file,
  			strerror(errno));
+		close(fd);
  		return 1;
  	}
  	if (!S_ISBLK(st.st_mode)) {
  		fprintf(stderr, "'%s' is not a block device\n", file);
+		close(fd);
  		return 1;
  	}
  	close(fd);

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux