Re: [PATCH] Btrfs: check file extent type before anything else

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Nov 01, 2013 at 08:30:44AM +0100, Stefan Behrens wrote:
> On Thu, 31 Oct 2013 16:50:43 -0400, Josef Bacik wrote:
> > I hit this problem with my no holes patch and it made me realize what the
> > problem was for bz 60834.  If the first item in the leaf is an inline extent and
> > we try to read anything starting from disk_bytenr onward we will read off the
> > end of the leaf.  So we need to check to see what it's type is, and if it's not
> > REG we can just break out.  This should fix this problem.  Thanks,
> > 
> > Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> > ---
> >  fs/btrfs/backref.c |  1 +
> >  fs/btrfs/send.c    | 10 +++++-----
> >  2 files changed, 6 insertions(+), 5 deletions(-)
> > 
> > diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
> > index 3775947..b763f10 100644
> > --- a/fs/btrfs/backref.c
> > +++ b/fs/btrfs/backref.c
> > @@ -1051,6 +1051,7 @@ static int btrfs_find_all_leafs(struct btrfs_trans_handle *trans,
> >  
> >  	if (ret < 0 && ret != -ENOENT) {
> >  		free_leaf_list(*leafs);
> > +		ulist_free(*leafs);
> 
> An en passant fix for which problem?
> 

Oops, sorry about that, not a problem just me doing other things, I'll drop that
bit.  Thanks,

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux