Re: [PATCH v3 02/12] Btrfs-progs: introduces '-p' option to print the ID of the parent qgroups

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 07, 2013 at 03:21:38PM +0800, Wang Shilong wrote:
> +static void print_parent_column(struct btrfs_qgroup *qgroup)
> +{
> +	struct btrfs_qgroup_list *list = NULL;
> +
> +	list_for_each_entry(list, &qgroup->qgroups, next_qgroup) {
> +		printf("%llu/%llu", (list->qgroup)->qgroupid >> 48,
> +		      ((1ll << 48) - 1) & (list->qgroup)->qgroupid);

Please use a wrapper for the >> 48 calculations everywhere (another
patch).

thanks,
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux