Re: [PATCH] Btrfs: Simplify the logic in alloc_extent_buffer() for existing extent buffer case

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > +struct extent_buffer *find_extent_buffer(struct extent_io_tree *tree,
> > > +					 u64 start, unsigned long len)
> > 
> > len isn't used.
> 
> Thought about removing the unused argument. But didn't know all the
> history behind why it was there in the first place. So, didn't bother
> it.
> 
> You think I should remove it.

Yeah, I would remove it.  Leave the tiny job of adding it to whoever
needs it in the future.  Until then we don't need the noise.

> How does this commit message sound:

Yup, seems fine to me.

Reviewed-by: Zach Brown <zab@xxxxxxxxxx>

- z
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux