On Tue, Oct 01, 2013 at 08:25:38PM +0800, Wang Shilong wrote: > > * -l sounds less intuitive, I suggest to use -r as for > > 'referenced', given that there is -e for 'exclusive'. > > Yeah, here -l means limited size. Anyway, this is a little obscure. > Maybe -r is better, but it may let user think it is a qgroup's referenced size > but not max referenced size.. The referenced and exclusive sizes are always printed, I think that's ok to assign -r to the referenced limit. If we want to reserve -r for something else, next option is to use -R and -E for the limits. During the time I was testing it the 2 most frequent uses were '-t' or '-tcle'. > > * the size should be pretty-printed by default or in bytes if a > > commandline option is given > > Agree, maybe i can add an options for example '-h' here. -h prints help. But we haven't solved selecting units in other commands as well, so this should be possibly done consistently and in one go. > > * in the long term, the tabular output would be much better as > > default, and the current terse output available via commandline option > > for batch processing > > The main reason that i don't use table result as default is because there > are so many columns here, and my first table result will be a head name like: > > rfer excl max_refer max_excl > ---- ----- ----------- ------------- > > In order to keep compatibility with previous 'btrfs qgroup show', i add '-t'. That's fine for now. -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
