Re: [PATCH] btrfs-progs: Add version.h dependency to fix parallel builds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/17/13 8:56 PM, Eric Sandeen wrote:
> Change the suffix rule to ensure that version.h is 
> built before we try to create any .o file.
> 
> Reported-by: Roy Li <rongqing.li@xxxxxxxxxxxxx>
> Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx>
> ---
> 
> I dunno, does this work?  My gnu make is rusty.

I'm actually confused by what the makefile is doing with the
dependency generation, maybe my patch isn't right.

this:

%.o.d: %.c
        $(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<

completely confuses me :)

-Eric

> diff --git a/Makefile b/Makefile
> index 3d715d8..d25054f 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -107,13 +107,13 @@ endif
>  %.o.d: %.c
>  	$(Q)$(CC) -MM -MG -MF $@ -MT $(@:.o.d=.o) -MT $(@:.o.d=.static.o) -MT $@ $(AM_CFLAGS) $(CFLAGS) $<
>  
> -.c.o:
> +%.o: %.c version.h
>  	@$(check_echo) "    [SP]     $<"
>  	$(Q)$(check) $(AM_CFLAGS) $(CFLAGS) $<
>  	@echo "    [CC]     $@"
>  	$(Q)$(CC) $(AM_CFLAGS) $(CFLAGS) -c $<
>  
> -%.static.o: %.c
> +%.static.o: %.c version.h
>  	@echo "    [CC]     $@"
>  	$(Q)$(CC) $(AM_CFLAGS) $(STATIC_CFLAGS) -c $< -o $@
>  
> --
> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux