Re: [PATCH] btrfs-progs: btrfs.8.in: Add info about reverting back to root subvolume.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 13, 2013 at 11:02:10AM +0530, chandan wrote:
> On Thursday, September 12, 2013 03:29:52 PM David Sterba wrote:
> > The number 5 is an implementation detail, we should recommend to use 0.
> >
> In the current btrfs kernel code if 0 is passed as the subvolume id,
> the btrfs_ioctl_default_subvol() function sets the subvolume id to the
> objectid of the current subvolume.

Uh, that's right.

> The patch provided at
> http://www.mail-archive.com/linux-btrfs@xxxxxxxxxxxxxxx/msg17973.html
> should fix the issue.

I think this is the intended behaviour, 'set-default 0' should set the
toplevel subvolume (ie id 5), the same way as the mount option
'subvolid'. I see that Alex came to the same conclusion in
http://www.mail-archive.com/linux-btrfs@xxxxxxxxxxxxxxx/msg17952.html

But, this should be fixed in kernel, so any tool that uses the ioctl
directly gets the same result.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux