Re: [PATCH 3/3] btrfs-progs: ctree: widen int->long due to PTR_ERR()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I'm not sure this change is necessary. The code is inherited from
kernel, I doubt that this would be wrong && unnoticed. PTR_ERR should
be always used after IS_ERR, this does all the typecasts and checks,
the final value is in the range of -MAX_ERRNO..0. MAX_ERRNO is 4095,
even if long is wider than int, there is no loss.

Did you turn on some extra compiler warnings?

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux