Re: [PATCH 2/5] btrfs-progs:local variable memory freed

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 05, 2013 at 10:38:55AM +0800, Gui Hecheng wrote:
> The local probe variable in is_ssd() freed upon unsuccessful return;

FYI, I've applied a patch from Wang Shilong "Btrfs-progs: fix compile
warning in is_ssd()" instead of the hunk below and will remove the
respective changelog line. The rest of your patch stays.

> @@ -1161,8 +1169,10 @@ static int is_ssd(const char *file)
>  
>  	/* Device number of this disk (possibly a partition) */
>  	devno = blkid_probe_get_devno(probe);
> -	if (!devno)
> +	if (!devno) {
> +		blkid_free_probe(probe);
>  		return 0;
> +	}
>  
>  	/* Get whole disk name (not full path) for this devno */
>  	blkid_devno_to_wholedisk(devno, wholedisk, sizeof(wholedisk), NULL);
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux