Re: [PATCH] Btrfs-progs: setup framework to corrupt specific fields of an inode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Aug 19, 2013 at 11:48:32AM -0400, Josef Bacik wrote:
> @@ -344,10 +442,12 @@ int main(int ac, char **av)
>  	ac = ac - optind;
>  	if (ac == 0)
>  		print_usage();
> -	if (logical == 0 && !extent_tree)
> +	if (logical == 0 && (!extent_tree && !inode))

There's a conflict with the chunk-recovery patches and this check does
not make sense with the -i & -f options. The one below is the one I'd
expect here, thus removing the one above.

>  		print_usage();
>  	if (copy < 0)
>  		print_usage();
> +	if ((inode && !strlen(field)) || (strlen(field) && !inode))
> +		print_usage();
>  
>  	dev = av[optind];
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux