Re: [PATCH] Btrfs: do not complete ordered extents that are truncated

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 27, 2013 at 01:20:14PM -0400, Josef Bacik wrote:
> Currently we will do the normal btrfs_finish_ordered_io if we invalidate a dirty
> page that is part of an ordered extent but hasn't yet been submitted for IO.
> The side effect of this is that when the rest of the ordered extent is completed
> it will still add its extent to the file and it's csums to the tree.  This
> usually isn't a problem since this occurs right before a truncate, so these
> csums and extents are going to be cleaned up.  However if there is an error
> doing the truncate we can leave extents that point to invalid data, and as such
> you'll get csum errors trying to read back this extent.  So to handle this just
> set a flag on the ordered extent if we are going to invalidate one of its dirty
> pages, and then once we go to do the completion stuff we skip updating the file
> extents and adding our csums, we just free everything up and exit.  This is
> preliminary work we need to have better orphan entry error handling.  Thanks,
> 
> Signed-off-by: Josef Bacik <jbacik@xxxxxxxxxxxx>
> ---

Ignore this, it is wrong.

Josef
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux