On 08/08/2013 07:02 PM, Jan Schmidt wrote:
>
> On Thu, August 08, 2013 at 07:04 (+0200), Wang Shilong wrote:
>> Signed-off-by: Wang Shilong <wangsl.fnst@xxxxxxxxxxxxxx>
>> Reviewed-by: Miao Xie <miaox@xxxxxxxxxxxxxx>
>> ---
>> fs/btrfs/backref.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c
>> index cb73a12..54e7610 100644
>> --- a/fs/btrfs/backref.c
>> +++ b/fs/btrfs/backref.c
>> @@ -911,7 +911,6 @@ again:
>>
>> while (!list_empty(&prefs)) {
>> ref = list_first_entry(&prefs, struct __prelim_ref, list);
>> - list_del(&ref->list);
>> WARN_ON(ref->count < 0);
>> if (ref->count && ref->root_id && ref->parent == 0) {
>> /* no parent == root of tree */
>> @@ -954,6 +953,7 @@ again:
>> eie->next = ref->inode_list;
>> }
>> }
>> + list_del(&ref->list);
>> kfree(ref);
>> }
>>
>>
>
> I'm not convinced, you're not calling kfree() more often. Can you please add
> some patch description?
Yeah. i will add more description in V2.
Thanks
Wang
>
> -Jan
>
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
