On Thu, Aug 8, 2013 at 11:52 AM, Stefan Behrens <sbehrens@xxxxxxxxxxxxxxxx> wrote: > On Thu, 4 Jul 2013 10:48:39 +0100, Filipe David Borba Manana wrote: >> Instead of aborting with a BUG_ON() statement, return a >> negated errno code. Also updated mkfs and convert tools >> to print a nicer error message when make_btrfs() returns >> an error. >> >> Signed-off-by: Filipe David Borba Manana <fdmanana@xxxxxxxxx> > [...] >> ret = pwrite(fd, buf->data, sectorsize, blocks[0]); >> - BUG_ON(ret != sectorsize); >> - >> + if (ret < 0) >> + return -errno; >> + else if (ret != leafsize) >> + return -EIO; > > mkfs.btrfs with leafsize != sectorsize fails. I've sent a patch for it. Copy paste error :( Thanks for catching and fixing it. > -- Filipe David Manana, "Reasonable men adapt themselves to the world. Unreasonable men adapt the world to themselves. That's why all progress depends on unreasonable men." -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
