From: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
The ret variant in the main function is not changed so even problems
happen, return value is still 0.
The patch fixs the minor bug and return 1 if any problems happen.
Signed-off-by: Qu Wenruo <quwenruo@xxxxxxxxxxxxxx>
---
btrfs-map-logical.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/btrfs-map-logical.c b/btrfs-map-logical.c
index e46d812..7dc71d3 100644
--- a/btrfs-map-logical.c
+++ b/btrfs-map-logical.c
@@ -119,7 +119,6 @@ int main(int ac, char **av)
int copy = 0;
u64 bytes = 0;
int out_fd = 0;
- int err;
while(1) {
int c;
@@ -187,8 +186,9 @@ int main(int ac, char **av)
out_fd = open(output_file, O_RDWR | O_CREAT, 0600);
if (out_fd < 0)
goto close;
- err = ftruncate(out_fd, 0);
- if (err) {
+ ret = ftruncate(out_fd, 0);
+ if (ret) {
+ ret = 1;
close(out_fd);
goto close;
}
@@ -205,8 +205,9 @@ int main(int ac, char **av)
while (bytes > 0) {
eb = debug_read_block(root, logical, root->sectorsize, copy);
if (eb && output_file) {
- err = write(out_fd, eb->data, eb->len);
- if (err < 0 || err != eb->len) {
+ ret = write(out_fd, eb->data, eb->len);
+ if (ret < 0 || ret != eb->len) {
+ ret = 1;
fprintf(stderr, "output file write failed\n");
goto out_close_fd;
}
--
1.8.0.1
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
