Re: [PATCH] btrfs-progs: per-thread, per-call pretty buffer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jul 10, 2013 at 11:31:17PM +0800, Wang Shilong wrote:
> Hello David,
> 
> > From: Zach Brown <zab@xxxxxxxxxx>
> > 
> duplicate information.

git-send-email tricked me, the line is not present in thre tree

> 
> > From: Zach Brown <zab@xxxxxxxxxx>
> > 
> > We don't need callers to manage string storage for each pretty_sizes()
> > call.  We can use a macro to have per-thread and per-call static storage
> > so that pretty_sizes() can be used as many times as needed in printf()
> > arguments without requiring a bunch of supporting variables.
> > 
> > This lets us have a natural interface at the cost of requiring __thread
> > and TLS from gcc and a small amount of static storage.  This seems
> > better than the current code or doing something with illegible format
> > specifier macros.
> > 
> > Signed-off-by: Zach Brown <zab@xxxxxxxxxx>
> > Signed-off-by: David Sterba <dsterba@xxxxxxx>
> 
> OK.  please add my tag: Acked-by: Wang Shilong <wangs.fnst@xxxxxxxxxxxxxx>
>  (I have given my tag in the previous thread to Zach and cc to you!)
> 
> Zach gives a better solution,but i at least report and try for it. Isn't it?

Oh sorry, I'll add the tag of course, I was so excited with zach's patch
and missed it.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux