Re: [PATCH v2] Btrfs-progs: remove incorrect slot decrement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ok, sorry.
I'm not used to git send-email and related best practices.

Thanks for letting me know.

On Mon, Jul 8, 2013 at 5:14 PM, David Sterba <dsterba@xxxxxxx> wrote:
> On Fri, Jul 05, 2013 at 09:43:34PM +0100, Filipe David Borba Manana wrote:
>> In btrfs_set_block_flags() we want to check if the slot
>> in the leaf points to the first item in the leaf - if it
>> doesn't check if the previous item in the leaf is an extent
>> item. By removing this extra slot decrement we are indeed
>> checking the item right before the slot, and not the second
>> item before.
>>
>> V2: Added Josef Bacik's review mention.
>
> Please don't do that. It's ok to increase version if you update code or
> changelog/subject, but not just the tags.
>
> thanks,
> david



-- 
Filipe David Manana,

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux