On 06/11/2013 04:00 AM, Eric Sandeen wrote:
On 6/10/13 9:56 AM, Anand Jain wrote:
btrfs_scan_for_fsid uses only one argument run_ioctl out of 3
so remove the rest two of them
and run_ioctl is only ever '1' (and it's completely unobvious
at the call point what '1' means).
There was this below patch for it. It was defined
as BTRFS_SCAN_REGISTER here.
subject: v6: access to backup superblock
I need to rebase this patch though.
Why not just go with 0 args?
Then only btrfs_scan_one_dir and btrfs_scan_block_devices
will have a non-obvious 0/1 arg.... :(
-Eric
btrfs_scan_for_fsid as such needs a revamp so that
it will use kernel-probes if device is mounted, so
as of now I would like to keep it as it is.
Thanks for the comments.
Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
