On Tue, May 28, 2013 at 09:43:07PM -0600, Miao Xie wrote: > On tue, 28 May 2013 14:50:25 -0400, Josef Bacik wrote: > > Stefan pointed out that xfstests generic/013 was failing because the free space > > cache checker was complaining with leafsize of 16k. Turns out this is because > > we were unconditionally using root->sectorsize as the free space ctl unit in the > > kernel, which doesn't work out if leafsize != sectorsize. This caused the in > > memory free space cache to get screwed up which translated to a wrong space > > cache on disk. This patch fixes the problem by not carrying the sectorsize in > > the block group since we have the ctl->unit, and we set the ctl->unit according > > to the type of block group we are. This made generic/013 pass with 16k > > leafsize, whereas before it failed every single time. Thanks, > > But this patch will make the old filesystem be corrupted because one bit in it > equals one sector(4K), not 16K. > Balls you're right, I'll fix progs and think about how to fix this at some point in the future. Thanks, Josef -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
