Re: [PATCH] Btrfs-progs: Add missing free() against fs_info->super_copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 27, 2013 at 01:31:13PM +0100, Filipe David Manana wrote:
> Right. Just thought it was better to check if the calloc() for fs_info
> succeeded before derreferencing it for free'ing its super_copy member
> (the function's code doesn't check if any of the malloc() / calloc()
> calls returned non-NULL, so it wouldn't be inconsistent with the
> existing code)

Sorry, I've read it too quickly, the check has to be there of course.

> >>       free(fs_info);
> >>       return NULL;
> >
> > otherwise ok. Thanks.
> 
> Thanks for review and advise.
> Do you need more action from my side?

No.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux