On Mon, Apr 22, 2013 at 12:18:37AM -0500, Eric Sandeen wrote: > There was a time when sprinkling #ifdefs around was > bad form. We can clean up the code a bit by moving > the leak-list adds/removes into functions and make things > more readable. > > Signed-off-by: Eric Sandeen <sandeen@xxxxxxxxxx> > --- > > V2: remove extra semicolons on no-op #defines, > thanks Roger! > > p.s. maybe _debug_ should be in the function names? > *shrug* I agree with that, makes things clear in the code, one does not need to look into that function. The leak_list members of extent_state and extent_buffer are present even without LEAK_DEBUG and are taking space, I'd like to see them moved under an #ifdef, but as the define is now local to the .c file this would need to add eg. a CONFIG_ option or a comment that describes how it should be used. Bug I'm fine with changing just the function names right now, the rest is optional and nice to have. Reviewed-by: David Sterba <dsterba@xxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
