On 4/3/13 11:04 AM, Zach Brown wrote: >> >> I was wondering if the transaction support should just be in the >> err: goto case, and went looking. > > Yeah, it's tempting. In the end I decided against it because this > shouldn't be so willing to freak out and make the file system read only. > It should try and undo the partial unlink and if *that* fails it should > go read only. I went for the minimal fix for now. > >> I'm not familiar enough with this stuff yet, but what if i.e. >> btrfs_delete_one_dir_name fails, should that also abort the >> transaction? > > It doesn't abort because its the first thing that can fail. It can > cleanly return an error without leaving partial state around. > > - z > Oh, sure. thanks - Reviewed-by: Eric Sandeen <sandeen@xxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
