Re: [PATCH 3/3 v4] btrfs-progs: disable using backup superblock by default

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 03/14/2013 12:36 PM, Eric Sandeen wrote:
On 3/13/13 10:05 PM, Anand Jain wrote:

<maybe a little more commit log would be good?>

So here is what confuses me now. :)

*every* caller of btrfs_read_dev_super() is now called with
0 for the flags variable, so it never reads the backup
under any circumstance.

If it's always called w/ 0, what is the point of the argument?
Is there another patch you have planned that would use this argument
later?

 Thanks for the review. yes true. as of now it (BTRFS_SCAN_BACKUP_SB)
 only serves the purpose if in future should we need it.
 purpose is something like a user initiated thread which
 should to go to the backup-SB if primary-SB is not found ?.
 Or I can drop BTRFS_SCAN_BACKUP_SB idea depending on how
 it is convenient as a whole.

Thanks,  Anand


--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux