> What errno values do you suggest? For me it's 'checksum is correct:
> yes/no', hence return 1/0.
Oh, I have no strong preerence here.
> I see an -EIO below, but that does not seem right here. There's a call
> to btrfs_read_dev_super that would indicate an unreadable block. We
> could use EFSCORRUPTED as xfs does (with value of EUCLEAN = 117) though.
>
> As implemented now, EINVAL will make 'mount' print the instructive
> message "look into the syslog", I'm not sure if we wouldn't need to
> update userspace to reflect the fine grained error codes.
Yeah, EINVAL seems reasonable. mount(2):
EINVAL source had an invalid superblock.
Documented (ish) and everything!
- z
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
