Hello, Eric, David 2013/2/27 Eric Sandeen <sandeen@xxxxxxxxxx>: > On 2/27/13 9:52 AM, David Sterba wrote: >> On Thu, Feb 21, 2013 at 08:26:15PM +0800, Wang Shilong wrote: >>> From: Wang Shilong <wangsl-fnst@xxxxxxxxxxxxxx> >>> >>> Steps to reproduce: >>> btrfs qgroup limit m <mnt>/subv >>> >>> Here, unit(k/K/g/G/m/M/t/T) all will trigger the problem. >>> For the above command, the original code will parse the limit value as 0 >>> and return successfully.It is wrong,fix it. >> >> I don't think we should allow to accept bare units for specifing >> numbers, so in that case fail with 'unrecognized limit'. > > I agree with that. > > Maybe since David didn't quite want to take my patch 01/17, and Zach > thought we needed better code for it all, and Goffredo didn't like > the exit() from parse_size, and now this problem, we need a single, > concerted effort to fix up size parsing. I Agre exit() should not be used in parse_size... But i don't agree with Zach about better code for it... Maybe like this: int parse_size(const char *s, u64 * size).. Many places that use the function parse_size/parse_limit, they have to be corrected after change.... Thanks, Wang > > Who knew it was so hard? :) > > -Eric > >> david >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in >> the body of a message to majordomo@xxxxxxxxxxxxxxx >> More majordomo info at http://vger.kernel.org/majordomo-info.html >> > -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
