On Tue, Feb 12, 2013 at 07:35:31PM -0800, Filipe Brandenburger wrote: > I really have concerns about the libification, in particular this commit: > > 6fc8b21 btrfs-progs: libify some parts of btrfs-progs [...] > I really don't think that all those headers should be exposed to the userspace. > > I think, to do it right, there should be a single or a few header > files, like /usr/include/btrfs.h or /usr/include/libbtrfs.h or > /usr/include/btrfs/xyz.h, that export only the parts that are really > necessary for an application that wants to use libbtrfs. Does it > really make sense to have btrfs-progs expose things like ctree.h or > crc32c.h or even list.h to userspace?! [...] For the record and public status of the libify patches: after the discussion on IRC a few days ago there is more work need to clean and finalize the header interfaces so that two currently proposed and future users of the library are satisfied. For that reason I'll not add libify patches into the integration branch directly, but keep it in a separate branch until all sides are ok, so that the integration branch is a relatively stable codebase for fixes and minor updates. That's my view of the situation, feel free to correct or update the bits I might have missed. david -- To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
