Re: What can I do to make btrfs work?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 13, 2013 at 06:31:37AM -0700, Chris Mason wrote:
> On Wed, Feb 13, 2013 at 06:10:44AM -0700, Richard W.M. Jones wrote:
> > On Wed, Feb 13, 2013 at 11:00:33AM +0000, Richard W.M. Jones wrote:
> > > Will try the btrfsprogs patch next.
> > 
> > I applied this patch:
> > 
> > https://git.kernel.org/?p=linux/kernel/git/mason/btrfs-progs.git;a=commitdiff_plain;h=8fe354744cd7b5c4f7a3314dcdbb5095192a032f
> > 
> > to the version of btrfs-progs in Fedora Rawhide (currently
> > "0.20.rc1.20121017git91d9eec").  Then I ran the simple reproducer, and
> > the full libguestfs test suite on two machines.
> > 
> > This does appear to fix the problem for me, but only on Rawhide.
> > 
> > On Fedora 18 which has an older kernel, the patch does not fix the
> > problem (same errors as before).
> > 
> > Rawhide kernel: kernel-3.8.0-0.rc7.git0.1.fc19.x86_64
> > 
> > Fedora 18 kernel: kernel-3.7.6-201.fc18.x86_64
> > 
> > Anyway, it's an improvement so I'll make sure the patch is added to
> > the Rawhide btrfs-progs package.
> 
> Ok, the patch is more of a bandaid, but between running my vtest program
> and the patch helping, we're clearly not clearing caches properly
> (somehow).  I'll take another stab at fixing this on the kernel side.

Looks like the real problem is the udev event to register a new btrfs
filesystem is racing in while we are still in mkfs.  If you disable the
udev rule, the problem goes away (at least for me).

It's not a udev bug though, our btrfs scanning function is improperly
calling set_blocksize during a simple scan.  That's only legal when we
are in mount and can't be racing with writes to the device.

Dave Sterba cooked up a fix for that, I'm testing it here.

-chris

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux