Re: [PATCH] Btrfs: Include the device in most error printk()s

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 13, 2013 at 03:25:31PM -0600, Simon Kirby wrote:
> With more than one btrfs volume mounted, it can be very difficult to find
> out which volume is hitting an error. btrfs_error() will print this, but
> it is currently rigged as more of a fatal error handler, while many of
> the printk()s are currently for debugging and yet-unhandled cases.

Please use btrfs_printk(fs_info, format, ...) for that purpose. That way
we can tune the message output format at one place. Also please do not
split format strings to more lines, this breaks grep when looking for
error messages in the sources.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux