Re: [PATCH] Btrfs: account for orphan inodes properly during cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Feb 01, 2013 at 04:05:17PM -0500, Josef Bacik wrote:
> Dave sent me a panic where we were doing the orphan cleanup and panic'ed
> trying to release our reservation from the orphan block rsv.  The reason for
> this is because our orphan block rsv had been free'd out from underneath us
> because the transaction commit found that there were no orphan inodes
> according to its count and decided to free it.  This is incorrect so make
> sure we inc the orphan inodes count so the accounting is all done properly.
> This would also cause the warning in the orphan commit code normally if you
> had any orphans to cleanup as they would only decrement the orphan count so
> you'd get a negative orphan count which could cause problems during runtime.
> Thanks,

Thanks. I've tried to reproduce it with an unpatched kernel, but was
unsuccesful (the same test was running for 3 days) and can't reliably
verify your fix. Looks like a very tiny race.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux