Re: [PATCH] Btrfs-prog/send: fix wrong dump_fd check in cmd_send_start()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Thu, Jan 31, 2013 at 04:21:24PM +0800, Chen Yang wrote:
>> In cmd_send_start(), there is a check to make sure dump_fd is not a tty
>> before parsing command options. So if we use the option "-f file",
>> it doesn't work for the dump_fd has not been created. So fix it.
> 
> Good catch, thanks. I see that there's no special handling of the '-'
> filename that usually means stdout. We may want to add this as a common
> command line usage pattern.
> 
> david
> 
We can touch a file name "-", so I think special handling of the '-' is unnecessary.

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux