here the code is correct, this base does not have
[PATCH] Btrfs-progs: filter the deleted subvolumes when listing snapshots
which introduced -ENOENT as a return for the resolve_root.
however since we should have that. I have integrated, and
made corresponding changes in the btrfs_get_subvol. Kindly
find V4.
Thanks, Anand
On 01/29/2013 02:04 AM, David Sterba wrote:
On Mon, Jan 28, 2013 at 08:42:06PM -0800, Wang Shilong wrote:
+ rbn = rb_first(&rl.root);
+ while(rbn) {
+ ri = rb_entry(rbn, struct root_info, rb_node);
+ resolve_root(&rl, ri, root_id);
Here subvolume/snapshot deletion may happen,add a check here...
if resolve_root return -ENOENT..it means deletion happens...
ret = reslove_root(&rl, ri, root_id);
if (ret)
goto again;
[...]
again???
+ rbn = rb_next(rbn);
+ }
Then it looks like a for (...) { } pattern with 'continue' instead of
'goto'.
david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
