Re: [PATCH 01/10] Btrfs-progs: move open_file_or_dir() to utils.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





Cool, I had this on my stack too.  But can you maybe remove the
nonsensical return values, and instead of renaming & keeping the btrfsctl.c
copy, why not just use a common copy in utils.c?  It'd just be 2 checks
for fd < 0 in the btrfsctl callers.

 Thanks for the comments Eric. Though I agree, but it deviates
 from the purpose of this patch-set. It could be taken as a
 separate patch.

Anand
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux