Re: [PATCH 1/5] Btrfs: fix repeated delalloc work allocation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On wed, 23 Jan 2013 14:06:21 +0800, Liu Bo wrote:
> On Wed, Jan 23, 2013 at 12:44:49PM +0800, Miao Xie wrote:
>> No, we can't. The other tasks which flush the delalloc data may remove the inode
>> from the delalloc list/splice list. If we release the lock, we will meet the race
>> between list traversing and list_del().
> 
> OK, then please merge patch 1 and 4 so that we can backport 1 less patch
> at least.

I don't think we should merge these two patch because they do two different things - one
is bug fix, and the other is just a improvement, and this improvement changes the logic
of the code and might be argumentative for some developers. So 2 patches is  better than one,
I think.

Thanks
Miao

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux