Re: [PATCH 06/13] btrfs-show-super.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/21/2013 11:46 AM, David Sterba wrote:
On Sun, Jan 20, 2013 at 04:04:11PM -0500, Gene Czarcinski wrote:
remove extra blank line at EOF
The patch contents and description do not match.
First of all, this patch should have been 2 separate patches. Too late to fix that.

The patch which created btrfs-show-super.c had an extra line at the end and I got annoyed at git-am complaining about it. This first patch fixes that. This should have been a separate commit.

The other patch (which should have been its own commit) addresses this problem:
http://www.mail-archive.com/linux-btrfs@xxxxxxxxxxxxxxx/msg19264.html

I could not see that it did any harm and it helped on at least one system type

I am not sure how it happened that I combined them. If you want, I will resubmit them the way it should be ... two separate patches with two separate commits.

Gene

--- a/man/Makefile
+++ b/man/Makefile
@@ -1,4 +1,4 @@
-GZIP=gzip
+GZIPCMD=gzip
I'm not sure if this change is needed, does it stick to some well-known
or established style in makefiles?

david



--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux