Re: [PATCH 05/13] Add btrfs-show-super

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 21, 2013 at 11:22:01PM +0100, Stefan Behrens wrote:
> On 01/21/2013 20:54, Goffredo Baroncelli wrote:
> >On 01/21/2013 07:04 PM, David Sterba wrote:
> >>On Sun, Jan 20, 2013 at 04:04:10PM -0500, Gene Czarcinski wrote:
> >>>From: Goffredo Baroncelli<kreijack@xxxxxxxxx>
> >>>
> >>What I'm missing here is Stefan's S-o-B line, as he's the original
> >>author of the tool, adding it, JFYI.
> >
> >I am not sure if he want to Sign it. During the review he blamed about
> >some style issues. But for time constraints I was not able to update the
> >patches.
> >
> >So before adding Stefen's S-o-B we need an ack from him.
> 
> For the record, all the extra spaces are not from me.

Thanks, s-o-b is there and I've removed them and added

@@ -125,7 +125,7 @@ int main(int argc, char **argv)

 static int load_and_dump_sb(char *filename, int fd, u64 sb_bytenr)
 {
-       u8      super_block_data[BTRFS_SUPER_INFO_SIZE];
+       u8 super_block_data[BTRFS_SUPER_INFO_SIZE];
        struct btrfs_super_block *sb;
        u64 ret;

@@ -166,12 +166,12 @@ static int check_csum_sblock(void *sb, int csum_size)

 static void dump_superblock(struct btrfs_super_block *sb)
 {
-       int     i;
-       char    *s, buf[36+1];
-       u8      *p;
+       int i;
+       char *s, buf[36+1];
+       u8 *p;
---

also a whitespace change, that sticks to the common style in progs.

david
--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux