Re: [PATCH 00/11 V3] add show command to the subvol sub command

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





 Any comments on this new sub-command, please. ?

Thanks, Anand


On 01/10/2013 07:41 PM, Anand Jain wrote:
This is an attempt to make btrfs cli more end user friendly.
And adds show subcommand to display all known (as of now)
information of the given subvol including its snapshot(s).

The below patch:
  "Btrfs-progs: accommodate different layout for printing subvol list"
obsoletes the previosuly submitted patch
  "Btrfs-progs: make provision to print subvol list tree format"

Please provide your review comments. Thanks.

An example output:

First list out all the subvols/snapshots using the list subcommand.

btrfs su list /btrfs
ID 256 gen 10 top level 5 path sv1
ID 259 gen 6 top level 5 path sv1/snap
ID 260 gen 7 top level 5 path snap
ID 261 gen 8 top level 5 path sv2
ID 262 gen 9 top level 5 path sv1/snap2
ID 263 gen 10 top level 5 path sv1/snap3

Then use show subcommand to know all known information about the
given subvol.

btrfs su show /btrfs/sv1
/btrfs/sv1
	uuid: 			508b12a5-ed2a-3942-af63-830967201070
	Parent uuid: 		-
	Creation time: 		2013-01-07 13:53:30
	Object ID: 		256
	Generation (Gen): 	10
	Gen at creation: 	5
	Parent: 		5
	Top Level: 		5
	Snapshot(s):
				sv1/snap
				sv1/snap2
				sv1/snap3


v2->v3: List snapshots of the given subvol if any.
         Uses a more simple approach to obtain the snapshots.

Anand Jain (11):
   Btrfs-progs: move open_file_or_dir() to utils.c
   Btrfs-progs: Move printing outside of btrfs_list_subvols
   Btrfs-progs: add parent uuid for snapshots
   Btrfs-progs: move struct root_info to btrfs-list.h
   Btrfs-progs: function to get root_info of a subvol
   Btrfs-progs: provide method to check if filter is set
   Btrfs-progs: add method to filter snapshots by parent uuid
   Btrfs-progs: put find_mount_root() in commands.h
   Btrfs-progs: maintain similar case in heading prefix
   Btrfs-progs: accommodate different layout for printing subvol list
   Btrfs-progs: add show to display all known parameters of the given
     subvol

  Makefile         |    4 +-
  btrfs-list.c     |  200 +++++++++++++++++++++++++++++++++++-------------------
  btrfs-list.h     |   60 +++++++++++++++-
  btrfsctl.c       |    7 +-
  cmds-balance.c   |    1 +
  cmds-inspect.c   |    1 +
  cmds-qgroup.c    |    1 +
  cmds-quota.c     |    1 +
  cmds-subvolume.c |  172 +++++++++++++++++++++++++++++++++++++++++++++-
  commands.h       |    6 +-
  common.c         |   46 ------------
  man/btrfs.8.in   |    6 ++
  utils.c          |   30 ++++++++-
  utils.h          |    3 +
  14 files changed, 405 insertions(+), 133 deletions(-)
  delete mode 100644 common.c

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-btrfs" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Filesystem Development]     [Linux NFS]     [Linux NILFS]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux